lkml.org 
[lkml]   [2007]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRE: [PATCH 10/23] make atomic_read() and atomic_set() behavior consistent on ia64
    Date
    From
    > Use volatile consistently in atomic.h on ia64.
    > This will do weird things without Andreas Schwab's fix:
    > http://lkml.org/lkml/2007/8/10/410

    The build is very noisy with the inline versions of atomic_{read,set}
    and their 64-bit siblings. Here are the prime culprits (some of them
    repeat >100 times).

    include/linux/skbuff.h:521: warning: passing arg 1 of `atomic_read' discards qualifiers from pointer target type
    include/net/sock.h:1244: warning: passing arg 1 of `atomic_read' discards qualifiers from pointer target type
    include/net/tcp.h:958: warning: passing arg 1 of `atomic_read' discards qualifiers from pointer target type
    mm/slub.c:3115: warning: passing arg 1 of `atomic_read' from incompatible pointer type
    mm/slub.c:3250: warning: passing arg 1 of `atomic_read' from incompatible pointer type
    mm/slub.c:3286: warning: passing arg 1 of `atomic_read' from incompatible pointer type

    The inline versions also result in some structural changes in
    the object file that make it difficult to compare with the
    original. Text size is 96 bytes smaller ... but even after
    I use sed(1) to exclude the most obvious instructions that
    differ, I still find big blocks of code with changes. Perhaps
    even more surprising there are entire functions that are
    optimized out in either the 'before' or 'after' binary.
    E.g. lookup_pi_state() was optimized away (or completely
    inlined?) before this patch, but the function appears as
    standalone in the 'after' version. The reverse is true for
    fixup_pi_state_owner().

    The binary does boot ... but I haven't run any tests to see whether
    there are any problems.

    -Tony
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-14 20:31    [W:0.024 / U:31.276 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site