lkml.org 
[lkml]   [2007]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] Firmware class name collision
    Hi,

    following patch fixes the i2c name collision with i2c-dev.

    http://mcentral.de/wiki/index.php/Bugtracker#i2c_core_problem

    This issue has been experienced with em28xx and saa7133 based devices.
    I discussed that problem with Jean Delvare a while ago and he proposed
    to add a prefix to the class name.

    http://mcentral.de/~mrec/patches/firmware_class_name_collision.diff

    Signed-off-by: Markus Rechberger <markus.rechberger@amd.com>

    index b24efd4..bfc54a1 100644
    --- a/drivers/base/firmware_class.c
    +++ b/drivers/base/firmware_class.c
    @@ -297,8 +297,7 @@ firmware_class_timeout(u_long data)

    static inline void fw_setup_device_id(struct device *f_dev, struct
    device *dev)
    {
    - /* XXX warning we should watch out for name collisions */
    - strlcpy(f_dev->bus_id, dev->bus_id, BUS_ID_SIZE);
    + snprintf(f_dev->bus_id, BUS_ID_SIZE, "fw-%s", dev->bus_id);
    }

    static int fw_register_device(struct device **dev_p, const char *fw_name,
    Markus


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-13 17:25    [W:0.024 / U:30.880 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site