Messages in this thread Patch in this message | | | Date | Mon, 13 Aug 2007 07:45:26 -0400 | From | Chris Snook <> | Subject | [PATCH 23/23] make atomic_read() and atomic_set() behavior consistent on xtensa |
| |
From: Chris Snook <csnook@redhat.com>
Use volatile consistently in atomic.h on xtensa.
Signed-off-by: Chris Snook <csnook@redhat.com>
--- linux-2.6.23-rc3-orig/include/asm-xtensa/atomic.h 2007-07-08 19:32:17.000000000 -0400 +++ linux-2.6.23-rc3/include/asm-xtensa/atomic.h 2007-08-13 06:31:58.000000000 -0400 @@ -15,7 +15,7 @@ #include <linux/stringify.h> -typedef struct { volatile int counter; } atomic_t; +typedef struct { int counter; } atomic_t; #ifdef __KERNEL__ #include <asm/processor.h> @@ -47,7 +47,10 @@ typedef struct { volatile int counter; } * * Atomically reads the value of @v. */ -#define atomic_read(v) ((v)->counter) +static inline int atomic_read(atomic_t *v) +{ + return *(volatile int *)&v->counter; +} /** * atomic_set - set atomic variable @@ -56,7 +59,10 @@ typedef struct { volatile int counter; } * * Atomically sets the value of @v to @i. */ -#define atomic_set(v,i) ((v)->counter = (i)) +static inline void atomic_set(atomic_t *v, int i) +{ + *(volatile int *)&v->counter = i; +} /** * atomic_add - add integer to atomic variable - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |