![]() | |||||||||||
Messages in this thread |
On Sunday 12 August 2007 11:25, Linus Torvalds wrote: > On Thu, 9 Aug 2007, Andi Kleen wrote:> > Some broken devices have been discovered to require %al/%ax/%eax > > registers for MMIO config space accesses. Modify mmconfig.c to use these > > registers explicitly (rather than modify the global readb/writeb/etc > > inlines).> >> > AK: also changed i386 to always use eax> > AK: moved change to extended space probing to different patch > > AK: reworked with inlines according to Linus' requirements. > > AK: improve comments.> >> > Signed-off-by: dean gaudet <dean@arctic.org>> > Signed-off-by: Andi Kleen <ak@suse.de>>> Damn you, Andi. Thanks for the kind words. > You had obviously never actually tested this on x86. Hmm, it booted on my i386 test box but it's possible it didn't use MCFG. >> > --- linux.orig/arch/i386/pci/mmconfig.c> > +++ linux/arch/i386/pci/mmconfig.c> > - writeb(value, mmcfg_virt_addr + reg);> > + mmio_config_writeb(mmcfg_virt_addr, value);>> Notice something missing here? The new code cannot work on any machine > that actually uses mmio cfg. Sigh. Ok I assume you already reverted and I'll send a new one. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||
| Last update: 2007-08-12 12:15 [from the cache] ©2003-2008 | |||||||||||