lkml.org 
[lkml]   [2007]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix triplefault on x86-64 bootup


On Sun, 12 Aug 2007, Linus Torvalds wrote:
>
> Hmm. Patch looks ok, I just wonder what started triggering this for you?

Oh. It's the "Make patching more robust" commit.

"Robust" my ass.

We used to just copy the replacement in one go (works fine, since it just
overwrote the two first bytes), and then "nop_out()" the rest (works fine,
since it didn't matter for memcpy).

That whole commit looks a bit dubious. It also adds a 254-byte stack
usage (anything actually even close to that big?). Gaah.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-08-12 11:01    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site