lkml.org 
[lkml]   [2007]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix triplefault on x86-64 bootup


On Sun, 12 Aug 2007, Andi Kleen wrote:
>
> Can you please just apply the patch series please?
> This one is fixed in "Make patching more robust, fix paravirt issue"

I *had* applied the patch series, Andi. And that one will do

memcpy(addr, opcode, len);

even though "addr" itself may be all of memcpy().

So the code was buggy, and Petr fixed it, and your patch-series didn't fix
*anything*. In fact, from what I can tell, it's the one that introduced
the problem, because before thatone hit, we'd always do the two-byte
sequence on its own (since the "nop_out()" on the rest of the memcpy would
be called later, and separately, once it didn't matter any more).

So out of 12 patches, 2 caused machines to not even boot. Not good.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-08-12 19:59    [W:0.212 / U:0.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site