lkml.org 
[lkml]   [2007]   [Aug]   [11]   [last100]   RSS Feed
Views: [more markup]   [less markup]   [headers]   [forward]  
 
Messages in this thread
Patch in this message
/
FromMariusz Kozlowski <>
Subject[PATCH -mm] drivers/scsi/megaraid.c: bugfix
DateSat, 11 Aug 2007 10:25:12 +0200
Hello,

	This is one of the 'possible downsides: embarrassment' situation described
by Randy in his papers on linux development. I introduced a bug while doin conversion
to kzalloc and this is a fix. We can not return here as we are under lock. Live and learn.

Please apply.

Regards,

	Mariusz

Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>

 drivers/scsi/megaraid.c | 116094 -> 116063 (-31 bytes)
 drivers/scsi/megaraid.o | 257984 -> 257868 (-116 bytes)
 drivers/scsi/megaraid.c |    3 ---
 1 file changed, 3 deletions(-)
--- linux-2.6.23-rc2-mm2-a/drivers/scsi/megaraid.c	2007-08-10 12:46:10.000000000 +0200
+++ linux-2.6.23-rc2-mm2-b/drivers/scsi/megaraid.c	2007-08-11 10:03:25.000000000 +0200
@@ -4409,9 +4409,6 @@ mega_internal_command(adapter_t *adapter
 	memset(scmd, 0, sizeof(Scsi_Cmnd));

 	sdev = kzalloc(sizeof(struct scsi_device), GFP_KERNEL);
-	if (!sdev)
-		return -ENOMEM;
-
 	scmd->device = sdev;

 	scmd->device->host = adapter->host;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2007-08-11 08:29    [from the cache]
©2003-2008