lkml.org 
[lkml]   [2007]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [SCSI] aic94xx: new driver
    From
    Date
    On Fri, 2007-08-10 at 23:09 +0800, David Woodhouse wrote:
    > On Sun, 2006-09-24 at 04:00 +0000, Linux Kernel Mailing List wrote:
    > > --- a/include/scsi/scsi.h
    > > +++ b/include/scsi/scsi.h
    > > @@ -429,4 +429,10 @@ #define SCSI_IOCTL_GET_BUS_NUMBER 0x5386
    > > /* Used to obtain the PCI location of a device */
    > > #define SCSI_IOCTL_GET_PCI 0x5387
    > >
    > > +/* Pull a u32 out of a SCSI message (using BE SCSI conventions) */
    > > +static inline u32 scsi_to_u32(u8 *ptr)
    > > +{
    > > + return (ptr[0]<<24) + (ptr[1]<<16) + (ptr[2]<<8) + ptr[3];
    > > +}
    > > +
    > > #endif /* _SCSI_SCSI_H */
    >
    > Please explain why it's necessary to export this to userspace.

    Er it's not ... but then it's not necessary to export this entire file,
    either.

    > The files in /usr/include/scsi are actually shipped by glibc, and most
    > distributions use glibc's version instead of the one from the kernel --
    > so this additional userspace interface is automatically incompatible
    > with most people's installations.
    >
    > It would perhaps make sense to stop glibc providing these files, and let
    > distributions use the version from the kernel -- but that's a separate
    > issue. And still doesn't seem to justify the addition of the above
    > function.

    >From the SCSI point of view, the function definitely belongs in that
    file because it's an accessor to facilitate the processing of commands
    and their replies, which is what that file contains ... in fact it
    contains a lot of the internal mechanics of the SCSI layer that the user
    shouldn't necessarily be seeing.

    James


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-08-10 17:55    [W:0.020 / U:59.176 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site