Messages in this thread |  | | | Date | Wed, 1 Aug 2007 13:24:42 -0300 | | From | Henrique de Moraes Holschuh <> | | Subject | Re: THINKPAD_ACPI_INPUT_ENABLED seems regressive |
| |
On Wed, 01 Aug 2007, Michael S. Tsirkin wrote: > Forcing the selection at compile-time isn't such a great idea IMHO. > Isn't there a way to support both old and new userspace?
It only afects the *defaults* of various driver knobs that can be freely modified at runtime:
without THINKPAD_ACPI_INPUT_ENABLED: hotkey_enable = 0 hotkey_mask unchanged from whatever is already set
hot keys from ibm-acpi 0.14 are mapped to KEY_UNKNOWN, and thus will generate ACPI events if hotkey_enabled is set to 1.
with THINKPAD_ACPI_INPUT_ENABLED: hotkey_enable = 1 hotkey_mask = hotkey_recommended_mask
most hot keys are mapped to something other than KEY_UNKNOWN, and thus will not generate ACPI events but rather input layer events.
You should select whichever works better with your userspace.
-- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |