Messages in this thread | | | From | Oleg Verych <> | Subject | Re: Coding style on function signatures (was: Convert tasklets to work queues ) | Date | Sun, 8 Jul 2007 06:02:26 +0000 (UTC) |
| |
>> static ssize_t >> store_fan_div (struct device *dev, struct device_attribute *devattr, >> const char *buf, size_t count) >> {...} >> >> >> IIRC, many like the entire sig on one line, because its grep friendly. >> I personally like the above, but grep-ability is hard to argue against. > > (I expect that "you" above means Linus, but anyway...) > > Some people like the above so that the function name can be grepped > using a "^store_fan_div" regex, but that's not good enough reason > for it for others, including Linus, IIRC.
Right. I was reading some LKML archives, and what i know, that returning type of the function is the first thing Linus cared about.
Newbies homework to think why (and care more about such things and not of the look).
-- -o--=O`C #oo'L O <___=E M
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |