Messages in this thread Patch in this message | | | Date | Sun, 08 Jul 2007 10:06:43 -0700 | From | Ulrich Drepper <> | Subject | Re: 2.6.22-rc6(mm1) Unable to handle kernel NULL pointer dereference - git-bisect result |
| |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Markus Trippelsdorf wrote: > I tested this further and it turned out that the Linus tree is also > affected. So I ran git-bisect, after I found out that version > 2.6.21.6 was not affected by this bug.
Try this patch. The vfs_permission test can be skipped since the VFS isn't involved. We got the inode etc from a file descriptor.
Signed-Off-By: Ulrich Drepper <drepper@redhat.com>
diff --git a/fs/utimes.c b/fs/utimes.c index 480f7c8..873edcb 100644 - --- a/fs/utimes.c +++ b/fs/utimes.c @@ -106,7 +106,8 @@ long do_utimes(int dfd, char __user *filename, struct timespec *times, int flags if (IS_IMMUTABLE(inode)) goto dput_and_out;
- - if (current->fsuid != inode->i_uid && + if (f == NULL && + current->fsuid != inode->i_uid && (error = vfs_permission(&nd, MAY_WRITE)) != 0) goto dput_and_out; }
- -- ➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) iD8DBQFGkRmj2ijCOnn/RHQRAkuyAJ41CIDhT8yKb6SKX14ylFXznO6gfwCfdtEo 4Gt9hPsotmKddwE2xdYkJmQ= =JyVn -----END PGP SIGNATURE----- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |