[lkml]   [2007]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    SubjectRe: 2.6.22-rc6(mm1) Unable to handle kernel NULL pointer dereference - git-bisect result
    Hash: SHA1

    Markus Trippelsdorf wrote:
    > I tested this further and it turned out that the Linus tree is also
    > affected. So I ran git-bisect, after I found out that version
    > was not affected by this bug.

    Try this patch. The vfs_permission test can be skipped since the VFS
    isn't involved. We got the inode etc from a file descriptor.

    Signed-Off-By: Ulrich Drepper <>

    diff --git a/fs/utimes.c b/fs/utimes.c
    index 480f7c8..873edcb 100644
    - --- a/fs/utimes.c
    +++ b/fs/utimes.c
    @@ -106,7 +106,8 @@ long do_utimes(int dfd, char __user *filename, struct timespec *times, int flags
    if (IS_IMMUTABLE(inode))
    goto dput_and_out;

    - - if (current->fsuid != inode->i_uid &&
    + if (f == NULL &&
    + current->fsuid != inode->i_uid &&
    (error = vfs_permission(&nd, MAY_WRITE)) != 0)
    goto dput_and_out;

    - --
    ➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
    Version: GnuPG v1.4.7 (GNU/Linux)
    -----END PGP SIGNATURE-----
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at
     \ /
      Last update: 2007-07-08 19:09    [W:0.020 / U:17.296 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site