Messages in this thread | | | Date | Sun, 08 Jul 2007 18:13:59 +0300 | From | Avi Kivity <> | Subject | Re: [PATCH][RFC] kvm-scheduler integration |
| |
Ingo Molnar wrote: > * Avi Kivity <avi@qumranet.com> wrote: > > >>>> Won't that increase task_struct (16 bytes on 64-bit) unnecessarily? >>>> The function pointers are common to all virtual machines. >>>> >>> well, this function pointer could then be reused by other virtual >>> machines as well, couldnt it? >>> >> I don't get this. If we add a couple of members to task_struct, it >> can't be reused. The values will be the same across all tasks, but >> the memory will be gone (including tasks which aren't virtual >> machines). >> > > i mean, the function pointer is set by KVM, but it could be set to a > different value by other hypervisors. > >
What other hypervisors? ;-)
Oh, if Rusty wants it for lguest I can put a pointer or a chain into task_struct. But I doubt it -- with paravirtualization there are no costly new registers to swap.
> but ... no strong feelings either way, your patch is certainly fine. > > Acked-by: Ingo Molnar <mingo@elte.hu> >
Thanks!
-- error compiling committee.c: too many arguments to function
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |