lkml.org 
[lkml]   [2007]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Disabling ADMA? (was Re: [PATCH] drivers/ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61)
    Jeff Garzik wrote:
    > Kuan Luo wrote:
    >> @@ -1714,3 +2761,6 @@ module_init(nv_init);
    >> module_exit(nv_exit);
    >> module_param_named(adma, adma_enabled, bool, 0444);
    >> MODULE_PARM_DESC(adma, "Enable use of ADMA (Default: true)");
    >> +module_param_named(ncq, ncq_enabled, bool, 0444);
    >> +MODULE_PARM_DESC(ncq, "Enable use of NCQ (Default: false)");
    >
    > After looking through sata_nv bug reports, I am leaning towards
    > disabling ADMA by default, and wanted to solicit comments.
    >
    > While admittedly not knowing the root cause, it seems like every current
    > outstanding sata_nv bug report that remains after switching out hardware
    > can be solved by setting module option 'adma' to zero. That's my first
    > suggestion upon any bugzilla sata_nv bug, and it usually works. You can
    > look through bugs assigned to or CC'd to jgarzik@pobox.com (kernel.org
    > bugs) jgarzik@redhat.com (redhat.com bugs) for examples.

    Do you have some specific bug numbers? Other than this one:

    http://bugzilla.kernel.org/show_bug.cgi?id=8421

    That one is hotplug-related, and it would seem only affects specific
    boards as it works fine for me. Likely NVIDIA input would be needed on
    that one to get much farther.

    I didn't find any other sata_nv ADMA-related bugs in the kernel.org or
    RH Bugzillas.

    Most of the reports I've gotten recently have been in one of these
    categories:

    -broken NCQ implementation on the drive (usually shows up as commands
    timing out with CPB resp_flags of 2)
    -cabling or power problems (often showing errors in the SError register)

    There have been a few reports yet of problems with commands getting
    issued and seeing to go nowhere. These can be difficult to diagnose.
    However, in some cases there's evidence leaning toward this being a
    drive issue as well, ex: this thread:

    http://groups.google.ca/group/linux.kernel/browse_frm/thread/2ebf329e3f6470eb/0d26dff9a30d29e9?lnk=gst

    Here there's a report of this drive model doing this on multiple
    controllers.

    Keep in mind, in the case where a broken NCQ implementation on the drive
    is the cause, disabling ADMA (and hence NCQ) will appear to "fix" the
    problem when the proper course of action would be to blacklist NCQ on
    that drive globally.

    Given the relative scarcity of problem reports (at least those I've
    seen), and the fact that this is not obscure hardware (they must have
    made millions of these nForce4 boards, and I think some may even still
    be in production), I'm reluctant to say we should be switching ADMA off
    by default.

    >
    > I still need to review the SWNCQ patch in detail, but I presume it is
    > possible to still use SWNCQ without ADMA?

    Yes, they're independent.

    >
    > On a side note, I would rather default SWNCQ to 'on'.


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-07 20:01    [W:0.030 / U:4.828 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site