lkml.org 
[lkml]   [2007]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] mm: fixup /proc/vmstat output
On Fri, Jul 06, 2007 at 01:35:34PM +0200, Peter Zijlstra wrote:
> Line up the vmstat_text with zone_stat_item
>
> enum zone_stat_item {
> /* First 128 byte cacheline (assuming 64 bit words) */
> NR_FREE_PAGES,
> NR_INACTIVE,
> NR_ACTIVE,
>
> We current have nr_active and nr_inactive reversed.

OK with patch, though using initializers canbe handy to prevent such
things in future:

static const char * const vmstat_text[] = {
[NR_FREE_PAGES] = "nr_free_pages",
...

> --- linux-2.6.orig/mm/vmstat.c
> +++ linux-2.6/mm/vmstat.c
> @@ -700,8 +700,8 @@ const struct seq_operations pagetypeinfo
> static const char * const vmstat_text[] = {
> /* Zoned VM counters */
> "nr_free_pages",
> - "nr_active",
> "nr_inactive",
> + "nr_active",
> "nr_anon_pages",
> "nr_mapped",
> "nr_file_pages",

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-06 19:21    [W:0.035 / U:1.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site