lkml.org 
[lkml]   [2007]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectWrite-only stuff in CFQ data structures
Jens, there are some write-only fields in cfq_data and cfq_queue to be
added in 2.6.22. I'm attaching patch to show what can be deleted, but
something suspicious is going on:

diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index baef5fc..eed7020 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -109,9 +109,6 @@ struct cfq_data {
unsigned int cfq_slice_idle;

struct list_head cic_list;
-
- sector_t new_seek_mean;
- u64 new_seek_total;
};

/*
@@ -151,8 +148,6 @@ struct cfq_queue {

/* various state flags, see below */
unsigned int flags;
-
- sector_t last_request_pos;
};

enum cfqq_state_flags {
@@ -1570,11 +1565,6 @@ cfq_update_io_seektime(struct cfq_data *cfqd, struct cfq_io_context *cic,
else
sdist = cic->last_request_pos - rq->sector;

- if (!cic->seek_samples) {
- cfqd->new_seek_total = (7*cic->seek_total + (u64)256*sdist) / 8;
- cfqd->new_seek_mean = cfqd->new_seek_total / 256;
- }
-
/*
* Don't allow the seek distance to get too large from the
* odd fragment, pagein, etc
@@ -1710,7 +1700,6 @@ cfq_rq_enqueued(struct cfq_data *cfqd, struct cfq_queue *cfqq,
cfq_update_idle_window(cfqd, cfqq, cic);

cic->last_request_pos = rq->sector + rq->nr_sectors;
- cfqq->last_request_pos = cic->last_request_pos;

if (cfqq == cfqd->active_queue) {
/*
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-06 16:55    [W:1.032 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site