lkml.org 
[lkml]   [2007]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -mm 5/9] netconsole: Introduce dev_status member
    On Wed, Jul 04, 2007 at 04:38:04PM +0530, Satyam Sharma wrote:
    > - if (!(event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME))
    > - goto done;
    > + if (!(event == NETDEV_UP || event == NETDEV_DOWN ||
    > + event == NETDEV_CHANGEADDR || event == NETDEV_CHANGENAME))
    > + goto done;
    >
    > if (nt->np.dev == dev) {
    > switch (event) {

    It's a small nit, but isn't the large if() just the degenerate
    default case of the switch()? Why have it at all?

    Joel

    --

    Life's Little Instruction Book #396

    "Never give anyone a fruitcake."

    Joel Becker
    Principal Software Developer
    Oracle
    E-mail: joel.becker@oracle.com
    Phone: (650) 506-8127
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-05 08:43    [W:0.021 / U:31.344 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site