lkml.org 
[lkml]   [2007]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateThu, 5 Jul 2007 10:48:06 +0200
FromIngo Molnar <>
SubjectRe: [PATCH] debug workqueue flushing deadlocks with lockdep

* Johannes Berg <johannes@sipsolutions.net> wrote:

> This patch adds a fake lock to each workqueue in order to debug things
> where you have something like
>
> my_function() -> lock(); ...; flush_workqueue(); ...
> vs
> run_workqueue() -> my_work() -> ...; lock(); ...
>
> which can obviously deadlock if my_work is scheduled when my_function()
> is invoked (but hasn't locked yet.)
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>

i'm still impressed by the elegancy of your idea :)

Acked-by: Ingo Molnar <mingo@elte.hu>

btw., small patch format comment: it would be useful (in the future) to
send such combined patches as:

[patch 0/2] general description
[patch 1/2] first patch
[patch 2/2] second patch

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-05 10:51    [from the cache]
©2003-2010