Messages in this thread |  | | | Subject | Re: [Intel IOMMU 01/10] DMAR detection and parsing logic | | From | Peter Zijlstra <> | | Date | Wed, 04 Jul 2007 12:14:58 +0200 |
| |
On Wed, 2007-07-04 at 03:04 -0700, Andrew Morton wrote: > On Wed, 04 Jul 2007 11:18:56 +0200 Peter Zijlstra <peterz@infradead.org> wrote: > > > On Tue, 2007-06-19 at 14:37 -0700, Keshavamurthy, Anil S wrote: > > > plain text document attachment (dmar_detection.patch) > > > > > +/** > > > + * parse_dmar_table - parses the DMA reporting table > > > + */ > > > +static int __init > > > +parse_dmar_table(void) > > > +{ > > > + struct acpi_table_dmar *dmar; > > > + struct acpi_dmar_header *entry_header; > > > + int ret = 0; > > > + > > > + dmar = (struct acpi_table_dmar *)dmar_tbl; > > > + > > > + if (!dmar->width) { > > ^^^^^^^^^^^^^^^^^^^ > > > > That goes *splat* on my opteron box. > > This? > > From: "Keshavamurthy, Anil S" <anil.s.keshavamurthy@intel.com> > > Check for dmar_tbl pointer as this can be NULL on systems with no Intel > VT-d support. > > Signed-off-by: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Ah, that does look sane, I'll test it whenever the next -mm comes around.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |