Messages in this thread | | | Date | Wed, 4 Jul 2007 10:00:29 -0700 | From | "Yinghai Lu" <> | Subject | Re: [PATCH 2/2] net: make net and forcedeth to use kmalloc_node |
| |
On 7/4/07, Christoph Hellwig <hch@infradead.org> wrote: > On Tue, Jul 03, 2007 at 11:58:40AM -0700, Andrew Morton wrote: > > > > > > while (np->put_rx.orig != less_rx) { > > > - struct sk_buff *skb = dev_alloc_skb(np->rx_buf_sz + NV_RX_ALLOC_PAD); > > > + struct sk_buff *skb = dev_alloc_skb_node(np->rx_buf_sz + NV_RX_ALLOC_PAD, dev_to_node(&dev->dev)); > > > > If we're going to do this then it would probably make sense to change > > dev_alloc_skb_node() so that it takes a `struct net_device *' rather than a > > bare node-id. That's a call which the net guys will need to make, which is > > why we cc them on our emails. > > That thing is called netdev_alloc_skb and already exists. And it's indeed > what they should be using in the rx path. > > - please check http://lkml.org/lkml/2007/7/3/418
[PATCH 3/4] net: make forcedeth to use kmalloc_node and __netdev_alloc_skb for skb allocation
but need to replace __netdev_alloc_skb to netdev_alloc_skb.
YH - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |