Messages in this thread | | | Date | Wed, 4 Jul 2007 09:54:00 -0700 | From | "Yinghai Lu" <> | Subject | Re: [PATCH 2/4] net: use numa_node in net_devcice->dev instead of parent |
| |
On 7/4/07, David Miller <davem@davemloft.net> wrote: > From: Christoph Hellwig <hch@infradead.org> > Date: Wed, 4 Jul 2007 09:51:20 +0100 > > > On Tue, Jul 03, 2007 at 05:30:51PM -0700, Yinghai Lu wrote: > > > [PATCH 2/4] net: use numa_node in net_devcice->dev instead of parent > > > > > > Signed-off-by: Yinghai Lu <yinghai.lu@sun.com> > > > diff --git a/net/core/skbuff.c b/net/core/skbuff.c > > > index 27cfe5f..005cc1c 100644 > > > --- a/net/core/skbuff.c > > > +++ b/net/core/skbuff.c > > > @@ -217,7 +217,7 @@ nodata: > > > struct sk_buff *__netdev_alloc_skb(struct net_device *dev, > > > unsigned int length, gfp_t gfp_mask) > > > { > > > - int node = dev->dev.parent ? dev_to_node(dev->dev.parent) : -1; > > > + int node = dev_to_node(&dev->dev); > > > > This looks wrong to me unless the device model has once again changed > > silently. When I wrote this code &dev->dev was a device allocated > > as part of the netdevice and the parent is the pci (or whatever) device > > that has the node information. > > Correct, this change is completely bogus. > -
please check that with
http://lkml.org/lkml/2007/7/3/419
[PATCH 1/4] try parent numa_node at first before using default
YH - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |