Messages in this thread | | | Date | Wed, 4 Jul 2007 14:00:58 +0200 | From | "andrzej zaborowski" <> | Subject | Re: Don't miss the ARM-scsi fix. |
| |
On 03/07/07, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote: > On Tue, Jul 03, 2007 at 12:21:45PM -0700, Andrew Morton wrote: > > On Tue, 3 Jul 2007 15:03:56 -0400 > > Rob Landley <rob@landley.net> wrote: > > > diff --git a/arch/arm/mach-versatile/pci.c b/arch/arm/mach-versatile/pci.c > > > index ba58223..ca82901 100644 > > > --- a/arch/arm/mach-versatile/pci.c > > > +++ b/arch/arm/mach-versatile/pci.c > > > @@ -117,7 +117,10 @@ static int versatile_read_config(struct pci_bus *bus, unsigned int devfn, int wh > > > } else { > > > switch (size) { > > > case 1: > > > - v = __raw_readb(addr); > > > + v = __raw_readl(addr); > > > + if (where & 2) v >>= 16; > > > + if (where & 1) v >>= 8; > > > > Someone's enter key broke? > > Probably, but I'd rather have the fix in than worry about that at this > stage.
It's just the case of being consistent with the already broken style in a function vs. correct style and inconsistency. I can never decide.
Regards, - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |