lkml.org 
[lkml]   [2007]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [Patch 09/16] Remove unnecessary kmalloc casts in the pci subsystem.
    Date
    Greg KH <gregkh@suse.de> writes:

    > On Tue, Jul 31, 2007 at 10:46:19PM +0800, WANG Cong wrote:
    >> However, I think using resource_size_t is a bit better than unsigned long,
    >> so that we don't need to check the defination of it.
    >>
    >> - res->start = (unsigned long)kmalloc(*size, GFP_KERNEL);
    >> + res->start = (resource_size_t)kmalloc(*size, GFP_KERNEL);
    >>
    >> Is this change OK?
    >
    > Yes, that is the proper cast to have here.

    It will generate a warning when resoure_size_t is 64bit on a 32bit arch.

    Andreas.

    --
    Andreas Schwab, SuSE Labs, schwab@suse.de
    SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
    PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
    "And now for something completely different."
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-31 18:23    [W:0.021 / U:119.036 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site