lkml.org 
[lkml]   [2007]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/7] sysfs: simplify sysfs_remove_dir()
    On Tue, 31 Jul 2007 19:15:08 +0900,
    Tejun Heo <htejun@gmail.com> wrote:

    > With the shadow directories gone, sysfs_remove_dir() can be simplified.
    >
    > * parent doesn't need to be grabbed separately. Just access
    > old_dentry->d_parent.
    >
    > * parent sd can never change. Remove code to move under the new
    > parent.
    >
    > * Massage comments a bit.
    >
    > Signed-off-by: Tejun Heo <htejun@gmail.com>
    > ---
    > fs/sysfs/dir.c | 26 ++++----------------------
    > 1 files changed, 4 insertions(+), 22 deletions(-)
    >
    It's not sysfs_remove_dir(), but sysfs_rename_dir() :) Otherwise this
    looks good.

    Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-31 15:01    [W:6.145 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site