lkml.org 
[lkml]   [2007]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 11/11] modules: better error messages when modules fail to load due to a sysfs problem.
    Date
    This helps people when debugging problems like the ones that were in the
    recent -mm releases.


    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    kernel/params.c | 7 ++++++-
    1 files changed, 6 insertions(+), 1 deletions(-)

    diff --git a/kernel/params.c b/kernel/params.c
    index effbaae..4e57732 100644
    --- a/kernel/params.c
    +++ b/kernel/params.c
    @@ -567,7 +567,12 @@ static void __init kernel_param_sysfs_setup(const char *name,
    kobject_set_name(&mk->kobj, name);
    kobject_init(&mk->kobj);
    ret = kobject_add(&mk->kobj);
    - BUG_ON(ret < 0);
    + if (ret) {
    + printk(KERN_ERR "Module '%s' failed to be added to sysfs, "
    + "error number %d\n", name, ret);
    + printk(KERN_ERR "The system will be unstable now.\n");
    + return;
    + }
    param_sysfs_setup(mk, kparam, num_params, name_skip);
    kobject_uevent(&mk->kobj, KOBJ_ADD);
    }
    --
    1.5.2.2
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-31 00:17    [W:0.020 / U:268.140 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site