Messages in this thread | | | Date | Wed, 4 Jul 2007 03:04:13 +0200 | From | "Jesper Juhl" <> | Subject | Re: [PATCH][isapnp] Fix a potential NULL pointer dereference in isapnp_read_tag() |
| |
On 03/07/07, Andrew Morton <akpm@linux-foundation.org> wrote: > On Sun, 1 Jul 2007 01:38:31 +0200 > Jesper Juhl <jesper.juhl@gmail.com> wrote: > > > The Coverity checker spotted (as bug #809) that we dereference 'type' > > long before we actually test it against NULL in > > drivers/pnp/isapnp/core.c::isapnp_read_tag() - both branches of the > > 'if (tag & 0x80)' dereference type, and since this 'if' is before the test > > against NULL and the return of -1, this will blow up is ever type is NULL. > > This is easy to fix by simply moving the NULL test to the beginning of > > the function. > > [snip] > > dood, look at the callers. NULL is not possible here. > You are right, there's absolutely no way that we could get a NULL pointer there - that was sloppy of me :-(
I guess we should just get rid of the check completely. I'll cook up a patch for that tomorrow.
-- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |