Messages in this thread | | | Subject | Re: [PATCH -mm] PM: Prevent frozen user mode helpers from failing the freezing of tasks (rev. 2) | From | Benjamin Herrenschmidt <> | Date | Wed, 04 Jul 2007 07:19:12 +1000 |
| |
> Actually, spinlock_t is not suitable. Because spin_unlcok() does NOT imply > mb(). The subsequent wait_event_timeout()->atomic_read() may leak into the > critical section. > > We can use set_mb(), if we don't want to play with smp_mb() by hand :)
spin_unlock implies a smp_wmb() but yeah, not a full mb(), though having a read leak into a critical section is generally not an issue.
Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |