Messages in this thread | | | Date | Tue, 3 Jul 2007 21:27:29 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH] Remove process freezer from suspend to RAM pathway |
| |
Hi!
> > > The main reason for deadlocks is because we do a sys_sync() after the > > > freeze, which we shouldn't do. > > > > So why don't we remove the sys_sync() from freeze_processes() instead? > > The patch follows (untested). > > Greetings, > Rafael > > > --- > From: Rafael J. Wysocki <rjw@sisk.pl> > > We shouldn't sync filesystems from within the freezer, because it's not needed > for suspend to RAM and leads to problems with FUSE.
Actually... It is not _needed_ for suspend to disk, either. Snapshot is atomic, so it should be okay to suspend with filesystems dirty.
_But_, if anything goes wrong, we'd prefer to have at least filesystems synced. Battery running out during s2ram is not quite uncommon, so we perhaps should do sync somewhere there. (But we can do it before freezer just fine). Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |