Messages in this thread | | | Date | Tue, 3 Jul 2007 16:26:55 +0100 | From | Alan Cox <> | Subject | Re: [PATCH] genericserial: Remove bogus optimisation check and dead code paths |
| |
On Tue, 03 Jul 2007 16:39:05 +0200 Morten Helgesen <morten@sourcepoet.org> wrote:
> Alan Cox wrote: > > [...snip...] > > @@ -75,11 +64,11 @@ > > if (! (port->flags & ASYNC_INITIALIZED)) return; > > > > /* Take a lock on the serial tranmit buffer! */ > > - LOCKIT; > > + mutex_lock(& port->port_write_mutex); > > > > ^ Contains additional whitespace.
Its an old driver, it doesn't follow the coding style too well at all - viz stuff like if (! ( the line above. Given its age and limited userbase I don't plan to go and make it conform either, but I will take patches for the formatting (and the spelling errors it is full of) from someone who wants to do the work.
Alan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |