lkml.org 
[lkml]   [2007]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/5] Use mutex instead of semaphore in the OnStream SCSI Tape driver
    Hi,


    On Sun, 29 Jul 2007, Matthias Kaehlcke wrote:

    > The OnStream SCSI Tape driver uses a semaphore as mutex. Use the mutex
    > API instead of the (binary) semaphore.
    >
    > Signed-off-by: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>
    > [...]
    > @@ -3298,7 +3298,7 @@ static ssize_t osst_write(struct file * filp, const char __user * buf, size_t co
    > char * name = tape_name(STp);
    >
    >
    > - if (down_interruptible(&STp->lock))
    > + if (mutex_lock_interruptible(&STp->lock))
    > return (-ERESTARTSYS);

    The () after return existed in the code already, but you could've felt
    free to remove them :-)

    > @@ -3619,7 +3619,7 @@ static ssize_t osst_read(struct file * filp, char __user * buf, size_t count, lo
    > char * name = tape_name(STp);
    >
    >
    > - if (down_interruptible(&STp->lock))
    > + if (mutex_lock_interruptible(&STp->lock))
    > return (-ERESTARTSYS);

    Same here.

    Reviewed-by: Satyam Sharma <satyam@infradead.org>
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-30 05:17    [W:0.032 / U:0.076 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site