lkml.org 
[lkml]   [2007]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/5] Use mutex instead of semaphore in the Host AP driver
Date
On Sunday 29 July 2007 23:34, Matthias Kaehlcke wrote:
> The Host AP driver uses a semaphore as mutex. Use the mutex API
> instead of the (binary) semaphore.
>
> Signed-off-by: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>
>
> --
>
> - res = down_interruptible(&local->rid_bap_sem);
> + res = mutex_lock_interruptible(&local->rid_bap_mtx);
> if (res)
> return res;
>
> @@ -902,7 +902,7 @@ static int hfa384x_set_rid(struct net_device *dev, u16 rid, void *buf, int len)
> /* RID len in words and +1 for rec.rid */
> rec.len = cpu_to_le16(len / 2 + len % 2 + 1);
>
> - res = down_interruptible(&local->rid_bap_sem);
> + res = mutex_lock_interruptible(&local->rid_bap_mtx);
> if (res)
> return res;
>

Is res returned to userspace? If yes, that's not right.
On a interrupted mutex allocation you should return
-ERESTARTSYS to userspace.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-30 00:09    [W:0.464 / U:0.340 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site