Messages in this thread | | | Date | Sat, 28 Jul 2007 20:42:01 +0200 | From | Gabriel C <> | Subject | Re: NETPOLL=y , NETDEVICES=n compile error ( Re: 2.6.23-rc1-mm1 ) |
| |
Andrew Morton wrote: > On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C <nix.or.die@googlemail.com> wrote: > >> Hi, >> >> I got this compile error with a randconfig ( http://194.231.229.228/MM/randconfig-auto-82.broken.netpoll.c ). >> >> ... >> >> net/core/netpoll.c: In function 'netpoll_poll': >> net/core/netpoll.c:155: error: 'struct net_device' has no member named 'poll_controller' >> net/core/netpoll.c:159: error: 'struct net_device' has no member named 'poll_controller' >> net/core/netpoll.c: In function 'netpoll_setup': >> net/core/netpoll.c:670: error: 'struct net_device' has no member named 'poll_controller' >> make[2]: *** [net/core/netpoll.o] Error 1 >> make[1]: *** [net/core] Error 2 >> make: *** [net] Error 2 >> make: *** Waiting for unfinished jobs.... >> >> ... >> >> >> I think is because KGDBOE selects just NETPOLL. >> > > Looks like it. > > Select went and selected NETPOLL and NETPOLL_TRAP but things like > CONFIG_NETDEVICES and CONFIG_NET_POLL_CONTROLLER remain unset. `select' > remains evil. > > Something like this.. > > --- a/lib/Kconfig.kgdb~kgdb-kconfig-fix > +++ a/lib/Kconfig.kgdb > @@ -175,8 +175,7 @@ endchoice > config KGDBOE > tristate "KGDB: On ethernet" if !KGDBOE_NOMODULE > depends on m && KGDB > - select NETPOLL > - select NETPOLL_TRAP > + depends on NETPOLL_TRAP && NET_POLL_CONTROLLER > help > Uses the NETPOLL API to communicate with the host GDB via UDP. > In order for this to work, the ethernet interface specified must > _ > >
That doesn't fix it. With that patch an 'make oldconfig' all NETPOLL stuff gone and we end up with :
...
drivers/built-in.o: In function `option_setup': /work/crazy/linux-git/MM/linux-2.6.23-rc1/drivers/net/kgdboe.c:160: undefined reference to `netpoll_parse_options' drivers/built-in.o: In function `configure_kgdboe': /work/crazy/linux-git/MM/linux-2.6.23-rc1/drivers/net/kgdboe.c:183: undefined reference to `netpoll_setup' /work/crazy/linux-git/MM/linux-2.6.23-rc1/drivers/net/kgdboe.c:189: undefined reference to `netpoll_cleanup' drivers/built-in.o: In function `eth_post_exception_handler': /work/crazy/linux-git/MM/linux-2.6.23-rc1/drivers/net/kgdboe.c:119: undefined reference to `netpoll_set_trap' drivers/built-in.o: In function `eth_pre_exception_handler': /work/crazy/linux-git/MM/linux-2.6.23-rc1/drivers/net/kgdboe.c:111: undefined reference to `netpoll_set_trap' drivers/built-in.o: In function `eth_flush_buf': /work/crazy/linux-git/MM/linux-2.6.23-rc1/drivers/net/kgdboe.c:138: undefined reference to `netpoll_send_udp' drivers/built-in.o: In function `eth_get_char': /work/crazy/linux-git/MM/linux-2.6.23-rc1/drivers/net/kgdboe.c:127: undefined reference to `netpoll_poll' drivers/built-in.o: In function `cleanup_kgdboe': /work/crazy/linux-git/MM/linux-2.6.23-rc1/drivers/net/kgdboe.c:217: undefined reference to `netpoll_cleanup' make: *** [.tmp_vmlinux1] Error 1
...
If I get that right select is needed here because all NETPOLL{_*} depends on if NETDEVICES && if NET_ETHERNET.
Also doing ... select NETPOLL_TRAP select NETPOLL select NET_POLL_CONTROLLER ...
makes the driver happy and everything compiles fine.
I think there may be a logical issue ( again if I got it right ). We need some ethernet card to work with kgdboe right ? but we don't have any if !NETDEVICES && !NET_ETHERNET.
So maybe some ' depends on ... && NETDEVICES!=n && NET_ETHERNET!=n ' is needed too ?
( really sory if I said something stupid these Kconfig depends are not really easy to figure for me )
Gabriel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |