[lkml]   [2007]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 08/68] 0 -> NULL, for arch/m68k
Yoann Padioleau wrote:
> When comparing a pointer, it's clearer to compare it to NULL than to 0.

> stram_start = phys_to_virt(0);
> - kernel_in_stram = (stram_start == 0);
> + kernel_in_stram = (stram_start == NULL);

stram_start is more like an offset than pointer, IMHO. And 0 is a valid
offset. The "==NULL" does not make much sense in this particular case.
NULL is usually used when checking for an uninitialized pointer, right?


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2007-07-27 13:39    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean