lkml.org 
[lkml]   [2007]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH]gx-suspmod.c use boot_cpu_data instead of current_cpu_data
    On Wed, Jul 25, 2007 at 09:26:38PM -0700, Andrew Morton wrote:
    > On Thu, 26 Jul 2007 04:20:10 +0000 "Dave Young" <hidave.darkstar@gmail.com> wrote:
    >
    > > >On 7/25/07, Andrew Morton <akpm@linux-foundation.org> wrote:
    > > > On Wed, 25 Jul 2007 14:19:05 +0000 Dave Young <hidave.darkstar@gmail.com> wrote:
    > > >
    > > > > Hi,
    > > > > in preemptible kernel will report BUG: using smp_processor_id() in preemptible, so use boot_cpu_data instead of current_cpu_data.
    > > > >
    > > > > Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
    > > > >
    > > > > ---
    > > > > arch/i386/kernel/cpu/cpufreq/gx-suspmod.c | 4 ++--
    > > > > 1 file changed, 2 insertions(+), 2 deletions(-)
    > > > >
    > > > > diff -pur linux/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c linux.new/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c
    > > > > --- linux/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c 2007-07-25 14:11:06.000000000 +0000
    > > > > +++ linux.new/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c 2007-07-25 13:57:29.000000000 +0000
    > > > > @@ -181,8 +181,8 @@ static __init struct pci_dev *gx_detect_
    > > > > struct pci_dev *gx_pci = NULL;
    > > > >
    > > > > /* check if CPU is a MediaGX or a Geode. */
    > > > > - if ((current_cpu_data.x86_vendor != X86_VENDOR_NSC) &&
    > > > > - (current_cpu_data.x86_vendor != X86_VENDOR_CYRIX)) {
    > > > > + if ((boot_cpu_data.x86_vendor != X86_VENDOR_NSC) &&
    > > > > + (boot_cpu_data.x86_vendor != X86_VENDOR_CYRIX)) {
    > > > > dprintk("error: no MediaGX/Geode processor found!\n");
    > > > > return NULL;
    > > > > }
    > > >
    > > > um, I suspect it really wants to get at the current CPU. But putting a
    > > > preempt_disable() around just that code is meaningless: the current CPU
    > > > could change immediately before or after the code block. It needs deeper
    > > > fixing, methinks.
    > > The only target is to get the cpu vendor, so boot_cpu_data is enough,
    > > the drivers/mtd/nand/cs553x_nand.c has the same usage.
    >
    > I think there's some vague ambition in there to support non-identical CPUs.
    > In which case reading from the local CPU would make more sense. (waves
    > frantically at cpufreq developers).

    a non-identical CPU system with a geode + something else doesn't exist
    and is very unlikely to happen.

    Dave

    --
    http://www.codemonkey.org.uk
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-26 18:51    [W:0.043 / U:29.844 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site