lkml.org 
[lkml]   [2007]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: pte_offset_map for ppc assumes HIGHPTE
    From
    Date
    On Thu, 2007-07-26 at 01:18 +0200, Andreas Schwab wrote:
    > Satya <satyakiran@gmail.com> writes:
    >
    > > hello,
    > > The implementation of pte_offset_map() for ppc assumes that PTEs are
    > > kept in highmem (CONFIG_HIGHPTE). There is only one implmentation of
    > > pte_offset_map() as follows (include/asm-ppc/pgtable.h):
    > >
    > > #define pte_offset_map(dir, addr) \
    > > ((pte_t *) kmap_atomic(pmd_page(*(dir)), KM_PTE0) + pte_index(addr))
    > >
    > > Shouldn't this be made conditional according to CONFIG_HIGHPTE is
    > > defined or not
    >
    > kmap_atomic is always defined with or without CONFIG_HIGHPTE.
    >
    > > (as implemented in include/asm-i386/pgtable.h) ?
    >
    > I don't think that needs it either.

    Depends... if you have CONFIG_HIGHMEM and not CONFIG_HIGHPTE, you are wasting
    time going through kmap_atomic unnecessarily no ? it will probably not do anything
    because the PTE page is in lowmem but still...

    Ben.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-26 01:25    [W:0.018 / U:61.672 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site