Messages in this thread | | | Date | Wed, 25 Jul 2007 21:54:07 +0400 | From | Sergei Shtylyov <> | Subject | Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface |
| |
Hello, I wrote:
>>diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/boot/dts/mpc8349emitx.dts >>index db0d003..f8f0e8a 100644 >>--- a/arch/powerpc/boot/dts/mpc8349emitx.dts >>+++ b/arch/powerpc/boot/dts/mpc8349emitx.dts >>@@ -37,6 +37,15 @@ >> reg = <00000000 10000000>; >> }; >> >>+ ide@f0000000 { >>+ compatible = "mmio-ide"; >>+ device_type = "ide";
> Why not "ata"?
Also, what mmio-ide in the compat properly means in the context of ide_platform which is able to handle both port and memory mapped IDE. I think we must get rid with this crap, and since this IDE register mapping is pretty much board specific, call it something like "mpc8349emitx-ide" instead.
MBR, Sergei - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |