lkml.org 
[lkml]   [2007]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 2.6.23-rc1: BUG_ON in kmap_atomic_prot()
    On Tue, 24 Jul 2007 11:14:21 -0700 (PDT)
    Linus Torvalds <torvalds@linux-foundation.org> wrote:

    >
    >
    > On Tue, 24 Jul 2007, Adrian Bunk wrote:
    > >
    > > buffered_rmqueue() and prep_new_page() are static functions with only
    > > one caller each, and for the normal non-debug case it's a really nice
    > > optimization to have them inlined automatically.
    >
    > I'm not at all sure I agree.
    >
    > Inlining big functions doesn't actually tend to generally generate any
    > better code, so if gcc's logic is "single callsite - always inline", then
    > that logic is likely not right.
    >

    fwiw, -fno-inline-functions-called-once (who knew?) takes i386 allnoconfig
    vmlinux .text from 928360 up to 955362 bytes (27k larger).

    A surprisingly large increase - I wonder if it did something dumb. It
    appears to still correctly inline those things which we've manually marked
    inline. hm.

    It would be nice to defeat the autoinlining for debug purposes though.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-24 20:33    [W:2.379 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site