Messages in this thread Patch in this message | | | Date | Mon, 23 Jul 2007 16:12:09 +0800 | From | Fengguang Wu <> | Subject | Re: [PATCH 6/7] radixtree: introduce radix_tree_scan_hole() |
| |
On Mon, Jul 23, 2007 at 04:04:05PM +0800, Fengguang Wu wrote: > On Mon, Jul 23, 2007 at 05:58:02PM +1000, Nick Piggin wrote: > > Fengguang Wu wrote: > > >Introduce radix_tree_scan_hole(root, index, max_scan) to scan radix tree > > >for the first hole. It will be used in interleaved readahead. > > > > > >The implementation is dumb and obviously correct. > > >It can help debug(and document) the possible smart one in future. > > > > Reasonable function to want. Is radix_tree_scan_hole the best name? > > What about radix_tree_next_hole or _find_next_hole? (Andrew, any > > suggestions?) > > Thank you! > > All comments seems reasonable, so I simply attach the updated patch. > > Fengguang > --- > Subject: radixtree: introduce radix_tree_next_hole() > Cc: Nick Piggin <nickpiggin@yahoo.com.au> > > Introduce radix_tree_next_hole(root, index, max_scan) to scan radix tree > for the first hole. It will be used in interleaved readahead. > > Cc: Nick Piggin <nickpiggin@yahoo.com.au> > Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn>
And another rename fix for the interleaved readahead patch.
Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn> --- mm/readahead.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.22-rc6-mm1.orig/mm/readahead.c +++ linux-2.6.22-rc6-mm1/mm/readahead.c @@ -372,7 +372,7 @@ ondemand_readahead(struct address_space pgoff_t start; read_lock_irq(&mapping->tree_lock); - start = radix_tree_scan_hole(&mapping->page_tree, offset, max+1); + start = radix_tree_next_hole(&mapping->page_tree, offset, max+1); read_unlock_irq(&mapping->tree_lock); if (!start || start - offset > max) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |