Messages in this thread | | | Date | Mon, 23 Jul 2007 17:23:37 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] compat_ioctl requires CONFIG_BLOCK |
| |
On Sat, 21 Jul 2007 01:08:57 +0200 Arnd Bergmann <arnd@arndb.de> wrote:
> On Saturday 21 July 2007, Sebastian Siewior wrote: > > > > Got with randconfig > > include/linux/loop.h:66: error: expected specifier-qualifier-list before > > 'request_queue_t' > > make[1]: *** [fs/compat_ioctl.o] Error 1 > > > > parts of compat ioctl require CONFIG_BLOCK to be set. > > > > Signed-off-by: Sebastian Siewior <sebastian@breakpoint.cc> > > Index: b/fs/compat_ioctl.c > > =================================================================== > > --- a/fs/compat_ioctl.c > > +++ b/fs/compat_ioctl.c > > @@ -63,7 +63,9 @@ > > __#include <linux/wireless.h> > > __#include <linux/atalk.h> > > __#include <linux/blktrace_api.h> > > +#ifdef CONFIG_BLOCK > > __#include <linux/loop.h> > > +#endif > > Adding #ifdef around an #include is considered bad style. Better just > make loop.h compile without any conditionals. Does the below > patch work for you?
This is the classic why-typedefs-are-bad. AFAIK there is no way of fixing this build error apart from adding otherwise-unneeded nested inclusions (very bad), or:
> Arnd <>< > > --- a/include/linux/loop.h > +++ b/include/linux/loop.h > @@ -63,7 +63,7 @@ struct loop_device { > struct task_struct *lo_thread; > wait_queue_head_t lo_event; > > - request_queue_t *lo_queue; > + struct request_queue *lo_queue; > struct gendisk *lo_disk; > struct list_head lo_list; > };
Good start. Now can we do the rest of the kernel? ;) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |