lkml.org 
[lkml]   [2007]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] update checkpatch.pl to version 0.08
Andy Whitcroft wrote:
> This version brings a number of new checks, and a number of bug
> fixes. Of note:
>
> - warnings for multiple assignments per line
> - warnings for multiple declarations per line
> - checks for single statement blocks with braces
>
> This patch includes an update for feature-removal-schedule.txt to
> better target checks.
>
> Andy Whitcroft (12):
> Version: 0.08
> check for spaces between function name and open parenthesis
>

> +# check for spaces between functions and their parentheses.
> + if ($line =~ /($Ident)\s+\(/ &&
> + $1 !~ /^(?:if|for|while|switch|return|volatile)$/ &&
> + $line !~ /$Type\s+\(/ && $line !~ /^.\#\s*define\b/) {
> + ERROR("no space between function name and open parenthesis '('\n" . $herecurr);
> + }


this somehow seems to match something completely non-related (a function pointer
declaration case):

ERROR: no space between function name and open parenthesis '('
#7278: FILE: drivers/net/e1000e/hw.h:434:
+ bool (*check_mng_mode)(struct e1000_hw *);

even if I put a space between ")(", it still complains.


Auke
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-24 01:39    [W:0.266 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site