lkml.org 
[lkml]   [2007]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [DRIVER SUBMISSION] DRBD wants to go mainline
> there is just one logical piece, the drbd module...
> it is all in its own subdirectory.

For review purposes the split is often file based.
Something along the lines of:

Makefile + Kconfig
include/linux/drdb* <= why 5 files for one module?
drdb_main.c
drdb_req.{c+h}
etc..

So essentially smaller pieces that can be revied but when ready for inclusion
it should go in as _one_ commit to avoid breaking bisect.

But please finish off all the CodingStyle issue before submission so the
review can concentrate on the actual content.

Quickly browsing drdb_int.h shows that there are a few issues yet to sort out.
typedef usage, funny macros, volatile etc.

Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-22 10:53    [W:0.132 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site