lkml.org 
[lkml]   [2007]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 2/5] kernel/time/clocksource.c: Use list_for_each_entry instead of list_for_each
    kernel/time/clocksource.c: Convert list_for_each to
    list_for_each_entry in clocksource_resume(),
    sysfs_override_clocksource() and show_available_clocksources()

    Signed-off-by: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>

    --

    diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
    index 51b6a6a..c8a9d13 100644
    --- a/kernel/time/clocksource.c
    +++ b/kernel/time/clocksource.c
    @@ -207,15 +207,12 @@ static inline void clocksource_resume_watchdog(void) { }
    */
    void clocksource_resume(void)
    {
    - struct list_head *tmp;
    + struct clocksource *cs;
    unsigned long flags;

    spin_lock_irqsave(&clocksource_lock, flags);

    - list_for_each(tmp, &clocksource_list) {
    - struct clocksource *cs;
    -
    - cs = list_entry(tmp, struct clocksource, list);
    + list_for_each_entry(cs, &clocksource_list, list) {
    if (cs->resume)
    cs->resume();
    }
    @@ -369,7 +366,6 @@ static ssize_t sysfs_override_clocksource(struct sys_device *dev,
    const char *buf, size_t count)
    {
    struct clocksource *ovr = NULL;
    - struct list_head *tmp;
    size_t ret = count;
    int len;

    @@ -389,12 +385,11 @@ static ssize_t sysfs_override_clocksource(struct sys_device *dev,

    len = strlen(override_name);
    if (len) {
    + struct clocksource *cs;
    +
    ovr = clocksource_override;
    /* try to select it: */
    - list_for_each(tmp, &clocksource_list) {
    - struct clocksource *cs;
    -
    - cs = list_entry(tmp, struct clocksource, list);
    + list_for_each_entry(cs, &clocksource_list, list) {
    if (strlen(cs->name) == len &&
    !strcmp(cs->name, override_name))
    ovr = cs;
    @@ -422,14 +417,11 @@ static ssize_t sysfs_override_clocksource(struct sys_device *dev,
    static ssize_t
    sysfs_show_available_clocksources(struct sys_device *dev, char *buf)
    {
    - struct list_head *tmp;
    + struct clocksource *src;
    char *curr = buf;

    spin_lock_irq(&clocksource_lock);
    - list_for_each(tmp, &clocksource_list) {
    - struct clocksource *src;
    -
    - src = list_entry(tmp, struct clocksource, list);
    + list_for_each_entry(src, &clocksource_list, list) {
    curr += sprintf(curr, "%s ", src->name);
    }
    spin_unlock_irq(&clocksource_lock);
    --
    Matthias Kaehlcke
    Linux Application Developer
    Barcelona

    The assumption that what currently exists must necessarily
    exist is the acid that corrodes all visionary thinking
    .''`.
    using free software / Debian GNU/Linux | http://debian.org : :' :
    `. `'`
    gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-07-22 20:53    [W:0.023 / U:59.924 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site