lkml.org 
[lkml]   [2007]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [ofa-general] [PATCH 1/5] ehca: Supports large page MRs
From
Date
Hi Roland!
> I applied this, but I agree with checkpatch.pl:
>
> > WARNING: externs should be avoided in .c files
> > #227: FILE: drivers/infiniband/hw/ehca/ehca_mrmw.c:67:
> > +extern int ehca_mr_largepage;
> >
> > WARNING: externs should be avoided in .c files
> > #949: FILE: drivers/infiniband/hw/ehca/hcp_if.c:753:
> > + extern int ehca_debug_level;
>
> if you need to use a variable in more than one .c file, put the extern
> declaration in a common header that's included everywhere you use the
> variable, including the .c file that it is defined in. That way the
> compiler can see if you get confused about the type of the variable.
That's true.
> When you get a chance, please post a follow-on patch to fix this.
Sure thing. Will do that for rc2.
Thanks!
Nam

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-21 10:25    [W:0.058 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site