[lkml]   [2007]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC][-mm PATCH 3/8] Memory controller accounting setup (v3)
On 7/20/07, Paul Menage <> wrote:
> On 7/20/07, Balbir Singh <> wrote:
> > + mem = mem_container_from_cont(task_container(p,
> > + mem_container_subsys_id));
> > + css_get(&mem->css);
> The container framework won't try to free a subsystem's root container
> state, so this isn't needed.

Sorry, this was a reply to the wrong patch hunk.

The css_get() in mem_container_create() is the unnecessary one.

Also, rather than doing something like:

mem_container_from_cont(task_container(p, mem_container_subsys_id))

you'd be better off defining a similar wrapper to
mem_container_from_cont() called mem_container_from_task() that uses
task_subsys_state() rather than container_subsys_state() - you'll save
a few indirections.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2007-07-20 22:43    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean