Messages in this thread | | | Date | Fri, 20 Jul 2007 13:39:58 -0700 | From | "Paul Menage" <> | Subject | Re: [RFC][-mm PATCH 3/8] Memory controller accounting setup (v3) |
| |
On 7/20/07, Paul Menage <menage@google.com> wrote: > On 7/20/07, Balbir Singh <balbir@linux.vnet.ibm.com> wrote: > > + mem = mem_container_from_cont(task_container(p, > > + mem_container_subsys_id)); > > + css_get(&mem->css); > > The container framework won't try to free a subsystem's root container > state, so this isn't needed.
Sorry, this was a reply to the wrong patch hunk.
The css_get() in mem_container_create() is the unnecessary one.
Also, rather than doing something like:
mem_container_from_cont(task_container(p, mem_container_subsys_id))
you'd be better off defining a similar wrapper to mem_container_from_cont() called mem_container_from_task() that uses task_subsys_state() rather than container_subsys_state() - you'll save a few indirections.
Paul - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |