lkml.org 
[lkml]   [2007]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] buggered kmalloc()
    On Fri, Jul 20, 2007 at 04:03:40PM +0100, Al Viro wrote:
    > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    > ---
    > diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
    > index aebcd5f..7829ab1 100644
    > --- a/drivers/scsi/iscsi_tcp.c
    > +++ b/drivers/scsi/iscsi_tcp.c
    > @@ -1885,7 +1885,7 @@ static int iscsi_tcp_get_addr(struct iscsi_conn *conn, struct socket *sock,
    > struct sockaddr_in *sin;
    > int rc = 0, len;
    >
    > - addr = kmalloc(GFP_KERNEL, sizeof(*addr));
    > + addr = kmalloc(sizeof(*addr), GFP_KERNEL);
    > if (!addr)
    > return -ENOMEM;

    This seems like something that would be trivial to check for in checkpatch.

    Dave

    --
    http://www.codemonkey.org.uk
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-20 22:15    [W:0.022 / U:0.304 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site