Messages in this thread |  | | | Subject | Re: [git patches] two warning fixes | | From | Krzysztof Halasa <> | | Date | Fri, 20 Jul 2007 20:34:46 +0200 |
| |
Linus Torvalds <torvalds@linux-foundation.org> writes:
> More people *should* generally ask themselves: "was the warning worth it?" > and then, if the answer is "no", they shouldn't add code, they should > remove the thing that causes the warning in the first place.
Sure. If a routine uses must_check yet its return value may be safely ignored then that must_check is simply misplaced and should be removed. It does not mean all must_checks are bad - each of them isn't bad unless one can demonstrate it is.
Back to sysfs_create_bin_file() - if one can demonstrate a caller can safely ignore the return value (which, it seems, is the case), then exactly this very must_check should be removed. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |