![]() | |||||||||||||
Messages in this thread |
On 7/2/07, Andi Kleen <ak@suse.de> wrote: > On Monday 02 July 2007 13:43:23 Indan Zupancic wrote: > > On Mon, July 2, 2007 01:59, Andi Kleen wrote: > > > Well only those that could be already hung from user space > > > with setleds (that was also confirmed). Actually I thought > > > they didn't hang completely, but just stopped reacting to > > > the keyboard (which is actually pretty bad for every user > > > to be able to trigger) > > > > Pavel's lost key events, mine stopped reacting altogether. > > Did you try if the network was still alive? Perhaps it was > just a locked up keyboard. > > > > > > I guess the better way to handle those would be to find out the > > > minimum frequency of blinking that is still ok and rate limit it to that in > > > the keyboard driver. > > > > Dmitry already has a patch for that. He limited it to one event each 50 ms. > > Great. > > > > > > Anyways, Stephen's patch just doesn't make sense: > > > he clearly didn't understand the code at all. Before you > > > apply it and cripple it better drop the driver completely. > > > > CC'ing Dmitry, as I think he doesn't like the blink driver much either. ;-) > > Perhaps one of you geniuses who all hate it can find a better way to > solve the "video output dead after kexec; but need visual feedback to the user > while crash dumping" problem. I'm waiting for your patches. > I don't don't like it ;) Unfortunately too many people end up enabling it and having issues with their keyboards. Can we have it depend on DEBUG_KERNEL? And probably KEXEC as well? Another option would be for it not use panic_blink. Do your kexec kernels have atkbd support enabled? You could write an new "blink" input handler that would latch to keyboards supporting leds and blink by sending EV_LED events. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2007-07-02 14:33 [from the cache] ©2003-2008 | |||||||||||||