Messages in this thread Patch in this message | | | From | Andi Kleen <> | Subject | [PATCH for review] [11/48] x86_64: During VM oom condition, kill all threads in process group | Date | Thu, 19 Jul 2007 15:48:40 +0200 (CEST) |
| |
From: Will Schmidt <will_schmidt@vnet.ibm.com>
During a VM oom condition, kill all threads in the process group.
We have had complaints where a threaded application is left in a bad state after one of it's threads is killed when we hit a VM: out_of_memory condition.
Killing just one of the process threads can leave the application in a bad state, whereas killing the entire process group would allow for the application to restart, or otherwise handled, and makes it very obvious that something has gone wrong.
This change allows the entire process group to be taken down, rather than just the one thread.
Signed-off-by: Will <will_schmidt@vnet.ibm.com> Signed-off-by: Andi Kleen <ak@suse.de> Cc: Andi Kleen <ak@suse.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> ---
arch/x86_64/mm/fault.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/arch/x86_64/mm/fault.c =================================================================== --- linux.orig/arch/x86_64/mm/fault.c +++ linux/arch/x86_64/mm/fault.c @@ -569,7 +569,7 @@ out_of_memory: } printk("VM: killing process %s\n", tsk->comm); if (error_code & 4) - do_exit(SIGKILL); + do_group_exit(SIGKILL); goto no_context; do_sigbus: - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |