Messages in this thread | | | Date | Wed, 18 Jul 2007 19:45:19 +0100 (BST) | From | Hugh Dickins <> | Subject | Re: [PATCH] Check for compound pages in set_page_dirty() |
| |
On Wed, 18 Jul 2007, Jens Axboe wrote: > > OK, you clearly have more knowledge in that area than I, but I do wish > that you would have made a note in the code at least to remove things > like this. It's pretty ugly to have superflous tests like that, > especially since there was not even a comment saying _why_ you could not > call set_page_dirty() on a compound page. I see it in the commit text, > but nobody looking at fs/bio.c or fs/direct-io.c would directly find any > reference of that. > > Could you submit a patch removing the tests?
Okay, I'll do that - once I've reminded myself how to test it and done so!
Hugh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |