lkml.org 
[lkml]   [2007]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [git patches 1/2] warnings: attack valid cases spotted by warnings
On Tue, Jul 17, 2007 at 05:42:39PM -0400, Jeff Garzik wrote:
> commit ae97fec3701a559929c3529e35417fab133a4d39
> Author: Jeff Garzik <jeff@garzik.org>
> Date: Tue Jul 17 01:08:29 2007 -0400
>
> drivers/usb/misc/auerswald: fix status check, remove redundant check
>
> 1) We should only set 'actual_length' output variable if usb length is
> known to be good.
>
> 2) No need to check actual_length for NULL. The only caller always
> passes non-NULL value.
>
> Signed-off-by: Jeff Garzik <jeff@garzik.org>

I have no objection to this patch at all, however it does not remove the
compiler warning :(

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-18 17:49    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site