lkml.org 
[lkml]   [2007]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Use tty_schedule in VT code.

    > On Tue, 17 Jul 2007, Paul Fulghum wrote:
    > >
    > > The scheduling is to move the processing out of interrupt context.
    > > The receive data is often extracted from the hardware
    > > at interrupt time and then queued for processing.
    >
    > You misunderstand.
    >
    > If the "delay" is zero, then why are you using "delayed" workqueues at
    > all?
    >
    > A delay of zero tends to be pointless. It's not a delay at all, and you
    > could just use the regular NON-DELAYING workqueues.

    Because sometimes you do want the delay. In other parts of the tty
    code we do delay. What should be done is

    if (tty->low_latency)
    flush_to_ldisc(&tty->buf.work.work);
    else
    schedule_delayed_work(&tty->buf.work, 1);

    Is this acceptable to you?

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-07-17 21:55    [W:0.031 / U:30.100 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site